Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Feature MOI #51

Merged
merged 33 commits into from Jan 10, 2020
Merged

WIP: Feature MOI #51

merged 33 commits into from Jan 10, 2020

Conversation

Wikunia
Copy link
Owner

@Wikunia Wikunia commented Dec 15, 2019 •
edited

Needs at least:

  • Test cases
    • Sudoku
    • Killer
    • Graph coloring
  • Able to set objective
  • Updated docs
  • Ability for parameters like: logs and backtrack
  • Test for maximizing objective
  • Benchmarking

@codecov
Copy link

codecov bot commented Dec 15, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@1c7cfb2). Click here to learn what that means.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #51   +/-   ##
=========================================
  Coverage          ?   98.56%           
=========================================
  Files             ?       19           
  Lines             ?     1393           
  Branches          ?        0           
=========================================
  Hits              ?     1373           
  Misses            ?       20           
  Partials          ?        0
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 94.11% <100%> (ø)
src/equal.jl 100% <100%> (ø)
src/MOI_wrapper/constraints.jl 100% <100%> (ø)
src/eq_sum.jl 100% <100%> (ø)
src/ConstraintSolver.jl 97.98% <100%> (ø)
src/all_different.jl 98.34% <100%> (ø)
src/hashes.jl 100% <100%> (ø)
src/MOI_wrapper/results.jl 81.25% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c7cfb2...fd0fcc9. Read the comment docs.

@Wikunia Wikunia mentioned this pull request Jan 5, 2020
Closed
@Wikunia
Merge branch 'master'
b053abd 
Conflicts:
	benchmark/killer_sudoku/cs.jl
	src/ConstraintSolver.jl
	src/eq_sum.jl
@Wikunia
add SingleVariableConstraint to hashes
a25a309
@Wikunia
Copy link
Owner Author

Wikunia commented Jan 9, 2020 •
edited

Last step:
Compare benchmark runs:

  • Sudoku
  • Killer sudoku
  • Graph coloring

@Wikunia
Copy link
Owner Author

Wikunia commented Jan 10, 2020

Benchmarks are a bit different because JuMP uses a different variable ordering which changes the hashes of the constraints and therefore the ordering they are called.
Graph coloring is worse because the objective changed.
Additionally there might a bit overhead on sudoku solving.
-> Finding larger test cases. #53

@Wikunia Wikunia merged commit d173321 into master Jan 10, 2020
@Wikunia Wikunia deleted the feature-moi branch January 10, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Wikunia